{GamParse} Finishing blows

[bpt82282]

I am running GamParse v1.5.2.17 and I play on Phinigel. I have suppress Finishing Blows selected, but I am still getting 32k hits showing up on parses where a character gets a finishing blow. I can go trim some logs to specific fights if that would help.

[Beimeith]

That would help, yes. If you can copy+paste the actual line from the log of the finishing blow, the damage+message that would help. If they changed the message slightly it might have messed it up.

[bpt82282]

So I cannot upload the log, but here is the short section of the finishing blow. I am assuming the issue is either because finishing blow isn't on the same line as the damage or because the damage is being shown twice.

[Fri Feb 09 22:14:11 2018] You crush a super-plated gnomework for 963 points of damage.
[Fri Feb 09 22:14:11 2018] Gainus scores a Finishing Blow!
[Fri Feb 09 22:14:11 2018] You crush a super-plated gnomework for 32844 points of damage.
[Fri Feb 09 22:14:11 2018] Your faction standing with Expedition 328 has been adjusted by -1.
[Fri Feb 09 22:14:11 2018] Your faction standing with Creep Reapers could not possibly get any better.
[Fri Feb 09 22:14:11 2018] A super-plated gnomework's corpse says, 'Signing off...bloop.'
[Fri Feb 09 22:14:11 2018] You crush a super-plated gnomework for 32844 points of damage.
[Fri Feb 09 22:14:11 2018] You have slain a super-plated gnomework!

[Beimeith]

So this was more involved than first glance as there were several issues.

First, as far as I can tell, originally finishing blows ended with 2 exclamation points, so GamParse was looking for that. I changed it to check for both versions (!! and !) however that was not the only issue.

I was told by reliable sources that the second Finishing Blow message is an error, that it only hits one time but has two messages. GamParse was only suppressing the first message, so it was still displaying the damage for the second hit.

So, I've changed it to work thusly:

1) Finishing Blow is now it's own Damage Type, meaning it will show as "Finishing" damage instead of "Crush" or "Slash" or w/e weapon type you are using.

2) GamParse will ALWAYS suppress the second damage message, regardless of setting.

3) If the Suppress Finishing Blows option is Enabled, GamParse will suppress the first damage message as well as the second.

[bpt82282]

Thanks